[SYCL][Graph] Update design doc for copy queue#362
[SYCL][Graph] Update design doc for copy queue#362mfrancepillois wants to merge 2 commits intosyclfrom
Conversation
mfrancepillois
added
the
Graph Implementation
mfrancepillois
requested review from
Bensuo,
EwanC,
julianmi,
ori-sky and
reble
Bensuo
force-pushed
the
maxime/update-doc-copy-queue
branch
2 times, most recently
from
7739b83 to
d5773eb
Compare
EwanC
left a comment
EwanC
left a comment
There was a problem hiding this comment.
nitpicked the design doc but LGTM
EwanC
left a comment
EwanC
left a comment
There was a problem hiding this comment.
Can we add an E2E test for a linear graph that interleaves memory and kernel commands. I'd like to verify that the interaction between our in-order command-list optimization and compute/copy command-lists works correctly.
I have added a test locally but actually the way it is right now the copy command list optimization will only happen for out-of-order command buffers. It might make sense to leave that as it is for now and work on combining these two optimizations if worth it as a further piece of work? |
Bensuo
force-pushed
the
maxime/update-doc-copy-queue
branch
from
73ba45c to
4a47e54
Compare
Bensuo
force-pushed
the
maxime/update-doc-copy-queue
branch
2 times, most recently
from
eb67857 to
020a5ff
Compare
EwanC
force-pushed
the
maxime/update-doc-copy-queue
branch
from
020a5ff to
0d13b58
Compare
- Update UR tag to include L0 command-buffer copy engine optimization - Add test which mixes copy and kernel commands - Update design doc to detail copy engine optimization
Co-authored-by: Kenneth Benzie (Benie) <k.benzie83@gmail.com>
EwanC
force-pushed
the
maxime/update-doc-copy-queue
branch
from
5d44bdf to
01b1582
Compare
3 participants
Update the design doc as command-buffer now uses the copy queue if a copy engine is available.