Draft
Conversation
|
hi, could you share where is the change of the sycl graph spec? |
Collaborator
Author
Hello, this isn't in the spec yet. This is a proof-of-concept implementation we are wanting to try with some workloads that use buffers internally before advertising in the spec. It may not be satisfactory by itself as it is only a partial solution - as it only extends the lifetime of buffers when the accessor is created inside the command-group with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ben's WIP work extending the lifetime of buffers used in a graph with
buffer::get_access(CGH)whenSYCL_GRAPH_EXTEND_BUFFER_LIFETIMESis set.TODO:
assume_buffer_outlives_graphconstraint could be relaxed when env var is set