[SYCL][DOC] Adding design document for command graph extension#183
Merged
reble merged 5 commits intosycl-graph-developfrom Jun 5, 2023
Merged
[SYCL][DOC] Adding design document for command graph extension#183reble merged 5 commits intosycl-graph-developfrom
reble merged 5 commits intosycl-graph-developfrom
Conversation
EwanC
reviewed
May 23, 2023
Collaborator
EwanC
left a comment
There was a problem hiding this comment.
Some other things I think it'd be worth documenting. Could be done in this PR, or in a follow-up:
- Relationship with a handler for processing command-groups to use in a node - had to fix this for capturing of temporaries bug.
- Sub-graphs - we create an empty node as an implementation detail to marshal all the dependencies.
- breadth-first approach - Once #182 is merged we should write down that implementation detail.
reble
commented
May 23, 2023
EwanC
approved these changes
May 31, 2023
Collaborator
EwanC
left a comment
There was a problem hiding this comment.
This is a good starting point.
Would also like to have sections with my previous suggestions, and also taking the comment content from
llvm/sycl/plugins/level_zero/pi_level_zero.cpp
Lines 8832 to 8889 in 452e7ae
But can write all that up in a follow-up PR.
Bensuo
approved these changes
May 31, 2023
reble
commented
May 31, 2023
reble
commented
May 31, 2023
reble
commented
May 31, 2023
reble
commented
May 31, 2023
Co-authored-by: Ewan Crawford <ewan@codeplay.com> Co-authored-by: Ben Tracy <ben.tracy@codeplay.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial draft of our implementation design documentation.