Remove deprecated enum validation #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
As this enum is deprected, it would be better to remove this line |
PJEilers
requested changes
Nov 19, 2025
Contributor
PJEilers
left a comment
PJEilers
left a comment
There was a problem hiding this comment.
As this enum is deprecated, it would be better to remove this line: ValidationCategoryEnum::validate($json['category']); in fromArray in Validation.php
nawaik
changed the title
Author
|
@PJEilers removed the |
PJEilers
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the ContactsApi::get function gives us the following exception:
Unexpected ENUM value in in class RealtimeRegister\\Domain\\Enum\\ValidationCategoryEnum: Esnic. Possible values: (General, IisNu, IisSe, Nominet, SKNic)This seems to be related to the depreciation of this enum in the previous tag. The enum is still used in
src/Domain/Validation::fromArray.