Fix contact update #52
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling and testing of empty string fields in update operations for both contacts and domains APIs. The main focus is to ensure that empty values are correctly passed and validated in the payloads, and that the test infrastructure supports this verification.
Testing improvements for empty fields:
test_update_with_empty_fieldsinContactsApiUpdateTest.phpto verify that empty strings fororganization,state, andfaxare properly sent in the payload when updating a contact.test_update_empty_fieldsinDomainsApiUpdateTest.phpto verify that empty values forauthcode,ns, andkeyDataare properly sent in the payload when updating a domain.API and test infrastructure changes:
updatemethod inContactsApi.phpto check for string type before includingorganization,state, andfaxin the payload, ensuring empty strings are handled correctly.MockedClientFactory::assertRoutehelper to accept and validate expected fields in the request body, supporting more robust payload verification in tests. [1] [2]