Improve standalone audio files' metadata #709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
Improves metadata extraction for standalone audio files (e.g., MP3) by aligning extracted contributor roles with common audiobook tagging conventions.
Changes:
- Merge audio “artist” tag values into
Metadata.authors. - Extract
Metadata.narratorsfrom audio “composer” tag values. - Document the new behavior in
CHANGELOG.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Sources/Streamer/Parser/Audio/AudioPublicationManifestAugmentor.swift | Updates AVFoundation metadata mapping to populate authors (including artist tags) and adds narrators (from composer tags). |
| CHANGELOG.md | Notes the improved standalone audio metadata extraction behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Streamer
narrators(from the composer metadata fields) and merges artist metadata intoauthors, following conventions used by common audiobook tools.cc @domkm, you might be interested as you implemented this feature first.