Fix build warnings #707
Merged
Fix build warnings #707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR addresses build warnings introduced after bumping to iOS 15 by migrating from the deprecated CoreServices framework to the modern UniformTypeIdentifiers framework, and updating related code patterns.
Changes:
- Migrated UTI struct from CoreServices to UniformTypeIdentifiers framework, replacing deprecated APIs with modern UTType-based implementations
- Updated UTI initialization in DocumentTypes to use failable initializers with compactMap instead of ExpressibleByStringLiteral conformance
- Changed DirectoryContainer enumerator iteration to use allObjects to fix iOS 15 compatibility
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Sources/Internal/UTI.swift | Complete refactoring to use UniformTypeIdentifiers framework instead of CoreServices; removed ExpressibleByStringLiteral conformance and added failable initializers |
| Sources/Shared/Toolkit/DocumentTypes.swift | Updated to use compactMap with new failable UTI initializers instead of map with string literals |
| Sources/Shared/Toolkit/File/DirectoryContainer.swift | Changed from direct enumerator iteration to enumerator.allObjects for iOS 15 compatibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address build warnings introduced since bumping to iOS 15.