[0.7.x] Improve PHP 8.5+ support by replacing binary cast with string cast #115
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
approved these changes
Aug 22, 2025
|
hey, you think it's sth merge-able ? :thanks: |
|
up |
WyriHaximus
changed the title
Member
|
Hey @kubawerlos, thank you for putting this PR together. Could you do either of these things for me so we can merge this PR in:
|
Contributor
Author
@WyriHaximus as I make a PR not from my personal account, but from org, I cannot do the former (I am assuming anyone can always squash the commits themself when merging), so I did the latter. |
WyriHaximus
added a commit
to WyriHaximus-labs/child-process
that referenced
this pull request
Dec 8, 2025
… cast This ports the changes from reactphp#115 to 0.6.x and buids up on reactphp#113 and 114.
Member
|
@kubawerlos Thank you for looking into this! The test suite currently reports this minor deprecation on PHP 8.5+, may I ask you to address this as well as part of this PR? 👍 |
Contributor
Author
|
@clue fixed |
clue
approved these changes
Dec 21, 2025
Member
clue
left a comment
clue
left a comment
There was a problem hiding this comment.
@kubawerlos Thanks for the update, changes LGTM, let's get this shipped! 
WyriHaximus
approved these changes
Dec 22, 2025
WyriHaximus
pushed a commit
to WyriHaximus-labs/child-process
that referenced
this pull request
Dec 22, 2025
… cast This ports the changes from reactphp#115 to `0.6.x` and buids up on reactphp#113 and reactphp#114.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.