🐛 Fix resource leaks causing CLOSE_WAIT connections #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed 5 instances of improper stream management that could cause CLOSE_WAIT connections in Apache when exceptions occur during file export operations. Changes: - PptxExporterController: Wrapped FileInputStream in try-with-resources for both diagramPPTX() and reactionPPTX() methods - SbxxExporterController: Wrapped InputStream in try-with-resources for both eventSBGN() and eventSBML() methods - CitationController: Wrapped InputStream in try-with-resources for exportCitation() method Previously, if IOUtils.copy() or flush() threw an exception, streams would not be closed, leaving file descriptors and HTTP connections in CLOSE_WAIT state. The try-with-resources pattern ensures proper cleanup even when exceptions occur. Note: HttpServletResponse.getOutputStream() is intentionally not closed as the servlet container manages its lifecycle. 🤖 Generated with Claude Code (https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed 5 instances of improper stream management that could cause CLOSE_WAIT connections in Apache when exceptions occur during file export operations.
Changes:
Previously, if IOUtils.copy() or flush() threw an exception, streams would not be closed, leaving file descriptors and HTTP connections in CLOSE_WAIT state. The try-with-resources pattern ensures proper cleanup even when exceptions occur.
Note: HttpServletResponse.getOutputStream() is intentionally not closed as the servlet container manages its lifecycle.
🤖 Generated with Claude Code (https://claude.com/claude-code)
@jweiser and I created this and compiled it, but did not run it. We are trying to fix the open Apache2 connections. We know you are on vacation. If you are not able to take a look, could you at least let us know if what is on prod is from the latest commit on the Master branch? And would it be safe to make this change inside and test it first, making sure it still runs?