Skip to content

Conversation

@ZakiFan
Copy link
Member

@ZakiFan ZakiFan commented Feb 5, 2021

了解了GRPC的使用方式。后面会把GRPC和Netty了解清楚。

@pinxiong
Copy link
Member

pinxiong commented Feb 6, 2021

@ZakiFan Thanks for your PR. It sounds good. However, there are several suggesstions for you as follows

  • There are four kinds of service method (Unary RPC, Server streaming RPC, Client streaming RPC and Bidirectional streaming RPC). Now, HelloWorld is the Unary RPC, so you'd better divide GrpcServer and GrpcClient to three different kinds of Server streaming RPC, Client streaming RPC and Bidirectional streaming RPC. If you do, it will make others understand better.

  • Keep the same code style, such as all of ***Server.java and ***Client.java are in the package io.grpc.examples

  • The rest of three kinds of server method are built by hello_streaming.proto and route_guide.proto, which are the official examples in grpc-java project, so you'd better use these to build the rest of server methods, because official examples can illustrate all features of grpc-java better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants