Added support for unit testing and migrations#2
Open
ghost wants to merge 23 commits intoreaction-eng:masterfrom
Open
Added support for unit testing and migrations#2ghost wants to merge 23 commits intoreaction-eng:masterfrom
ghost wants to merge 23 commits intoreaction-eng:masterfrom
Conversation
…ed mocking from google libs
Collaborator
|
Hi, Matt! It's taken me a while to take a look at this and it's a pretty big PR, so it will take me a while to look it all over. More testing, DB migrations, and mocks are all good enhancements, so I look forward to getting this merged. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I needed to make some changes to the caws api so I did some work to add unit tests and migration support to the rest lib. Please let me know what you think.