Skip to content

Remove duplicate routes declaration. Import common component. #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hasparus wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove duplicate routes declaration. Import common component. #59

hasparus wants to merge 1 commit into from

Conversation

@hasparus
Copy link

@hasparus hasparus commented Apr 13, 2018

Example solution for #58.
Makes code DRier :)

@piranna
Copy link
Collaborator

piranna commented Apr 13, 2018

I have been working on a more in-depth solution, and for example templates/re-start/App.js is not used anymore, just only templates/re-start/src/index.js instead of Main. Could you be able to change the names according to this?

@piranna
Copy link
Collaborator

piranna commented Apr 14, 2018

I have finished the pull-request for my refactor, if you want to take it a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hasparus @piranna