Skip to content

refactor: move onChange event up #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zombieJ merged 1 commit into from
May 13, 2025
Merged

refactor: move onChange event up #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/Step.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,11 +128,7 @@ export default function Step(props: StepProps) {
);

const wrapperNode = (
<div
className={cls(`${itemCls}-wrapper`, classNames.itemWrapper)}
style={styles.itemWrapper}
{...accessibilityProps}
>
<div className={cls(`${itemCls}-wrapper`, classNames.itemWrapper)} style={styles.itemWrapper}>
<div className={cls(`${itemCls}-icon`, classNames.itemIcon)} style={styles.itemIcon}>
{iconRender?.(renderInfo)}
</div>
Expand Down Expand Up @@ -170,6 +166,7 @@ export default function Step(props: StepProps) {
let stepNode: React.ReactNode = (
<div
{...restItemProps}
{...accessibilityProps}
className={classString}
style={{
...styles.item,
Expand Down
10 changes: 5 additions & 5 deletions tests/index.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,9 +210,9 @@ describe('Steps', () => {
]}
/>,
);
const items = container.querySelectorAll('.rc-steps-item-wrapper');
const items = container.querySelectorAll('.rc-steps-item');
fireEvent.click(items[1]);
expect(onChange).toBeCalledWith(1);
expect(onChange).toHaveBeenCalledTimes(1);
});

it('items out of render function', () => {
Expand All @@ -233,7 +233,7 @@ describe('Steps', () => {
<Steps current={current} onChange={onChange} items={items} key={current} />,
);

const step = container.querySelectorAll('.rc-steps-item-wrapper')[1];
const step = container.querySelectorAll('.rc-steps-item')[1];
fireEvent.click(step);
rerender(<Steps current={current} onChange={onChange} items={items} key={current} />);
expect(container.querySelectorAll('.rc-steps-item')[1].classList).toContain(
Expand Down Expand Up @@ -265,7 +265,7 @@ describe('Steps', () => {
/>,
);

const btn = container.querySelectorAll('.rc-steps-item-wrapper')[0];
const btn = container.querySelectorAll('.rc-steps-item')[0];
fireEvent.click(btn);
expect(onClick).toHaveBeenCalled();
});
Expand All @@ -276,7 +276,7 @@ describe('Steps', () => {
<Steps onChange={onChange} items={[{}, {}, { disabled: true }]} />,
);

const items = container.querySelectorAll('.rc-steps-item-wrapper');
const items = container.querySelectorAll('.rc-steps-item');
fireEvent.click(items[2]);
expect(onChange).not.toBeCalled();
});
Expand Down