Skip to content

fix: actions semantic #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zombieJ merged 5 commits into from
May 16, 2025
+4 −8
Merged

fix: actions semantic #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dcf7dda
fix: actions semantic
thinkasany May 16, 2025
90de905
fix
thinkasany May 16, 2025
85463cf
empty
thinkasany May 16, 2025
e0ddc17
chore: tmp of ajv install
zombieJ May 16, 2025
2d5a385
chore: bump father version
zombieJ May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"eslint-plugin-jest": "^28.10.0",
"eslint-plugin-unicorn": "^56.0.0",
"expect.js": "~0.3.1",
"father": "^4.1.1",
"father": "^4.5.5",
"glob": "^11.0.0",
"husky": "^9.1.7",
"jest-environment-jsdom": "^29.3.1",
Expand Down
7 changes: 1 addition & 6 deletions src/InputNumber.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,6 @@ const InternalInputNumber = React.forwardRef(
...inputProps
} = props;

const { classNames, styles } = React.useContext(SemanticContext) || {};

const inputClassName = `${prefixCls}-input`;

const inputRef = React.useRef<HTMLInputElement>(null);
Expand Down Expand Up @@ -619,10 +617,7 @@ const InternalInputNumber = React.forwardRef(
onStep={onInternalStep}
/>
)}
<div
className={clsx(`${inputClassName}-wrap`, classNames?.actions)}
style={styles?.actions}
>
<div className={`${inputClassName}-wrap`}>
<input
autoComplete="off"
role="spinbutton"
Expand Down
3 changes: 2 additions & 1 deletion tests/semantic.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,11 @@ describe('InputNumber.Semantic', () => {
classNames={testClassNames}
/>,
);

const input = container.querySelector('.rc-input-number')!;
const prefix = container.querySelector('.rc-input-number-prefix')!;
const suffix = container.querySelector('.rc-input-number-suffix')!;
const actions = container.querySelector('.rc-input-number-input-wrap')!;
const actions = container.querySelector('.rc-input-number-handler-wrap')!;
expect(input.className).toContain(testClassNames.input);
expect(prefix.className).toContain(testClassNames.prefix);
expect(suffix.className).toContain(testClassNames.suffix);
Expand Down
Loading