Add version to static files in production #1513
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
It is actually a bad idea to override the template tag. There are custom storage classes for this. ManifestStaticFilesStorage would also be an idea, but would also have the same issues as whitenoise. |
MyPyDavid
reviewed
Jan 16, 2026
| def url(self, name): | ||
| url = super().url(name) | ||
|
|
||
| if settings.DEBUG: |
Member
There was a problem hiding this comment.
we don't have a if settings.DEBUG check anywhere in rdmo yet, should this not go in the rdmo-app?
Member
Author
There was a problem hiding this comment.
No, I think its fine. settings.DEBUG is pretty low-level django. So far we did not need it.
jochenklar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overwrites the regular Django
statictemplate tag to add the current RDMO version (ifDEBUG = False). The result is that clients will drop the cached files when the version changes (aka. cache busting). There are some remarks around to not use query params for this (pointing to https://www.stevesouders.com/blog/2008/08/23/revving-filenames-dont-use-querystring/), but I don't think this is relevant for us.We might to switch to [whitenoise}(https://whitenoise.readthedocs.io/en/latest/) at some point, but we need to fix our JS and CSS pipeline first and get rid of compressor.