HG-299: Introduce interaction with cash register service #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Чтобы компиляция прошла нужно использовать эту версию damsel |
keynslug
reviewed
Dec 15, 2017
| {mg_proto_state_processing_thrift, 'EventSink'}; | ||
| get_service(cashreg) -> | ||
| {cashreg_proto_processing_thrift, 'CashRegister'}; | ||
| get_service(cashreg_provider) -> |
| Changes = [ | ||
| ?cashreg_receipt_session_finished(?cashreg_receipt_session_failed({ | ||
| receipt_registration_failed, #cashreg_main_ReceiptRegistrationFailed{ | ||
| reason = #cashreg_main_ExternalFailure{code = <<"0">>} |
Contributor
There was a problem hiding this comment.
TODO бы оставить на этот хардкод.
| ?invoice_payment_flow_instant() -> | ||
| ?captured(); | ||
| Status = get_receipt_status(St), | ||
| process_receipt_registration(Status, St); |
Contributor
There was a problem hiding this comment.
Непонятно, почему только в этом клозе.
| end; | ||
| merge_change(?receipt_ev(ID, Event, EventID), St) -> | ||
| St1 = St#st{activity = {receipt, ID}}, | ||
| Receipt = make_receipt_state(Event, EventID), |
Contributor
There was a problem hiding this comment.
Я бы предложил по образу остальных мест сделать, типа merge_receipt_event/2, и трекать корректно activity.
| St1 = set_session(Target, Session, St), | ||
| % FIXME leaky transactions | ||
| St2 = set_trx(get_session_trx(Session), St1), | ||
| St2 = set_trx(get_session_trx(Session), St1#st{activity = payment}), |
Contributor
There was a problem hiding this comment.
...И по идее вот здесь не придётся мудрить.
| [?receipt_ev(ReceiptID, ?receipt_registered(), EventID)]; | ||
| construct_payment_change(EventID, ReceiptID, ?cashreg_receipt_failed( | ||
| {receipt_registration_failed, #cashreg_main_ReceiptRegistrationFailed{ | ||
| reason = #cashreg_main_ExternalFailure{code = Code, description = Description} |
| options = CashRegOptions | ||
| } | ||
| }) -> | ||
| Revision = hg_domain:head(), |
Contributor
There was a problem hiding this comment.
Опасно. Можно сверху передать?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.