[RFC] properties: upgrade HBaseVertex to support multi-properties#57
Open
rappazzo wants to merge 1 commit intorayokota:masterfrom
Open
[RFC] properties: upgrade HBaseVertex to support multi-properties#57rappazzo wants to merge 1 commit intorayokota:masterfrom
rappazzo wants to merge 1 commit intorayokota:masterfrom
Conversation
Author
|
I have only tested a version of this change which was based on v1.0.10, but there is minimal differences between the two versions. You can see that version on my fork |
0f11dfb to
3265dde
Compare
The HBase graph tinkerpop implementation specifies Cardinality.single as the default. Since HBase does not (at the time of this writing) support multiple values, this feature wraps the multi-values in a list and writes the list to HBase. As a consequence of this list wrapper, indexed properties can still only support-single value properties. When reading/writing from HBase, most properties will be written as single objects. Only when a property is specifically added with non-single cardinality will it be written to HBase as a list. In order to avoid java native serialization, the serialization of non-single property values uses Kryo (with a small lightweight wrapper class to accomplish this).
3265dde to
8b00107
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HBase graph tinkerpop implementation specifies Cardinality.single as
the default. Since HBase does not (at the time of this writing) support
multiple values, this feature wraps the multi-values in a list and
writes the list to HBase. As a consequence of this list wrapper,
indexed properties can still only support-single value properties.
When reading/writing from HBase, most properties will be written as
single objects. Only when a property is specifically added with
non-single cardinality will it be written to HBase as a list.
In order to avoid java native serialization, the serialization of
non-single property values uses Kryo (with a small lightweight wrapper
class to accomplish this).