Skip to content

Enhance pipeline#4

Merged
ravishan16 merged 4 commits intomainfrom
enhance-pipeline
Oct 2, 2025
Merged

Enhance pipeline#4
ravishan16 merged 4 commits intomainfrom
enhance-pipeline

Conversation

@ravishan16
Copy link
Owner

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ravishan16, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the converSQL project by focusing on a complete UI/UX refresh, improving developer onboarding and documentation, and refactoring core AI components for better maintainability and robustness. The changes aim to provide a more polished and user-friendly application while also making the codebase easier to understand and contribute to.

Highlights

  • Comprehensive UI/UX Overhaul: The Streamlit application's user interface has undergone a significant redesign, introducing a new brand palette, custom CSS styling, and a more modern, cohesive look and feel across all pages, including a branded login experience.
  • Enhanced Developer Experience & Documentation: New copilot-instructions.md provides detailed guidance for developers. The CONTRIBUTING.md and README.md files have been significantly updated and streamlined, including new front-end styling guidelines and a concise overview of the project's architecture and features.
  • AI Prompt Management Refactoring: The large SQL generation prompt has been extracted from src/ai_service.py into a new dedicated src/prompts module, improving modularity and maintainability of AI-related logic.
  • Improved Type Safety and Robustness in AI Adapters: The Bedrock, Claude, and Gemini AI engine adapters have been updated with more explicit Optional type hints and null checks, preventing potential runtime errors and making the AI integration more robust.
  • New Branding Assets and Utilities: A new conversql_logo.svg has been added, along with a src/branding.py module to manage logo and favicon paths and data URIs, facilitating consistent branding across the application and documentation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a significant and impressive enhancement to the application's user interface, branding, and overall code quality. The UI has been completely overhauled with a professional and consistent design, leveraging a new color palette, logo, and CSS custom properties for better maintainability. The README.md and other documentation files have been substantially improved, providing much clearer guidance for users and developers.

Key improvements include:

  • A complete visual refresh with a new brand identity.
  • Refactoring of CSS to use variables and classes instead of inline styles.
  • Extraction of the AI prompt into a dedicated module, improving modularity.
  • Widespread improvements to type hinting and addition of None checks across the AI engine adapters, increasing code robustness and type safety.
  • A much-improved login page UX.

I've found a couple of issues to address: a structural bug in the HTML layout of the tabs and a minor violation of the newly introduced styling guidelines. Once these are fixed, this will be an excellent contribution to the project.

app.py Outdated
# label="📅 Data Vintage",
# value=PORTFOLIO_CONTEXT['overview']['vintage_range']

st.markdown("</div>", unsafe_allow_html=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This closing </div> tag is misplaced. It appears to be closing the <div class='section-card'> that was opened in the 'Query Builder' tab (tab1) at line 675. Closing it here within tab2 results in malformed HTML and can lead to unexpected layout issues.

The section-card div from tab1 should be closed within tab1 itself, likely after the query editing components and before tab2 is defined (around line 834). Please remove this line from here and ensure the div in tab1 is properly closed within its own tab.

Comment on lines 1081 to 1087
colors = [
"#3498db",
"#e74c3c",
"#f39c12",
"#2ecc71",
"#9b59b6",
"#F3E5D9",
"#E7C8B2",
"#F6EDE2",
"#E4C590",
"#ECD9C7",
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These colors are hardcoded, which goes against the new 'Front-end Styling' guideline in CONTRIBUTING.md that encourages using CSS custom properties. To align with the new styling architecture, consider defining these colors as CSS variables in the :root block at the top of the file. You could then create corresponding CSS classes and apply them dynamically.

For example:

In the <style> block:

:root {
  /* ... existing variables ... */
  --color-domain-card-1: #F3E5D9;
  --color-domain-card-2: #E7C8B2;
  /* ... etc. */
}
.domain-card-1 { background-color: var(--color-domain-card-1); }
.domain-card-2 { background-color: var(--color-domain-card-2); }

And in the Python loop:

color_index = i // 3 % len(colors)
st.markdown(f"""
<div class='domain-card-{color_index} ...'>
...
</div>
""", unsafe_allow_html=True)

This approach would centralize all color definitions and make the styling more maintainable.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@ravishan16 ravishan16 merged commit 83bf798 into main Oct 2, 2025
12 checks passed
@ravishan16 ravishan16 deleted the enhance-pipeline branch October 2, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments