Philox tests #5
Open
Philox tests #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aelizaro
commented
Jul 26, 2024
aelizaro
commented
- Discard fix
- Initial bunch of tests
iburyl
reviewed
Jul 29, 2024
rng/philox/philox.hpp
Outdated
| { | ||
| promotion_type tmp = z; | ||
| for(std::size_t j = 0; j < n; j++) { | ||
| z += (unsigned long long)x[j]; |
There was a problem hiding this comment.
promotion type is for result_type, not for unsigned long long.
Let unsigned long long be 64 bits; and result_type be 32 bits. promotion type will be 64 bits.
Same example; z=-1; x[0]=1; skipped nothing. Period of this thing is 2^(32*4+2) -> we are in wrong state.
Co-authored-by: Alexey Kukanov <alexey.kukanov@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.