Skip to content

Conversation

@royduin
Copy link
Member

@royduin royduin commented Dec 12, 2025

We've to double check these as the tests where failing for a while, the report url for better image comparison: https://rapidez.github.io/playwright-reports/rapidez/core/screenshot-update/20164425703/1/

Reference story for checking this as follow-up: RAP-1706

@royduin royduin requested a review from indykoning as a code owner December 12, 2025 11:54
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Products are missing in the sidebar

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just the name label change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Price filter changed form 32 to 24 which is correct as the cheapest product is for sale and priced 24, is that the only change here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other change is that the price symbol is behind the number now instead of before :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The category filter is gone?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The *at the super attribute label moved, do we really want/need them here in the listing?

Copy link
Member

@Roene-JustBetter Roene-JustBetter Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove it we don't need it.

@royduin royduin changed the title Screenshots update [5.x] Screenshots update Jan 7, 2026
@royduin
Copy link
Member Author

royduin commented Jan 8, 2026

The things left according: https://rapidez.github.io/playwright-reports/rapidez/core/screenshot-update/20818018289/1/#?q=s%3Afailed+chromium

  • Breadcrumbs a product page
  • Related products on a product page
  • Category filter on the search page is gone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants