-
Notifications
You must be signed in to change notification settings - Fork 13
[5.x] Screenshots update #1123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[5.x] Screenshots update #1123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Products are missing in the sidebar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just the name label change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Price filter changed form 32 to 24 which is correct as the cheapest product is for sale and priced 24, is that the only change here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other change is that the price symbol is behind the number now instead of before :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The category filter is gone?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The *at the super attribute label moved, do we really want/need them here in the listing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove it we don't need it.
|
The things left according: https://rapidez.github.io/playwright-reports/rapidez/core/screenshot-update/20818018289/1/#?q=s%3Afailed+chromium
|
We've to double check these as the tests where failing for a while, the report url for better image comparison: https://rapidez.github.io/playwright-reports/rapidez/core/screenshot-update/20164425703/1/
Reference story for checking this as follow-up: RAP-1706