load history file on startup for libedit#119
Open
dallinjdahl wants to merge 1 commit intorakitzis:masterfrom
Open
load history file on startup for libedit#119dallinjdahl wants to merge 1 commit intorakitzis:masterfrom
dallinjdahl wants to merge 1 commit intorakitzis:masterfrom
Conversation
Contributor
|
Thanks for this! Just one question: why do you |
Author
|
I don't want to read the entire history file, especially given that the default limit for history entries is 20. Given the possibility of extremely long history files (useful for analytics on usage patterns and so on), we just read in the last 5k, which should stay performant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plain text history file is ideal, but libedit deserializes history from it's own format. This loads the history file line by line.