Add optional logo-uri field to token spec #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See issues:
The token spec currently lacks support for token logos/icons. Token logos are a common requirement for UI applications and are already part of the tokenlists.org standard that we reference via
using-tokens-from. Adding this field allows tokens defined directly in YAML to include logo URIs, bringing parity with tokens imported from external token lists.Solution
Added an optional
logo-urifield to the token definition inob-yaml.md:logo-urito the optional fields list with the note "(fetch from token list)" to indicate the data sourcelogo-uri) to match existing field conventions likenetwork-id,vault-id, anddeployment-blockChecks
By submitting this for review, I'm confirming I've done the following:
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.