Skip to content

fix: make project android 16kb compatible#6804

Merged
jinchung merged 1 commit intodevelopfrom
@wolewicki/android-16kb
Aug 13, 2025
Merged

fix: make project android 16kb compatible#6804
jinchung merged 1 commit intodevelopfrom
@wolewicki/android-16kb

Conversation

@WoLewicki
Copy link
Contributor

@WoLewicki WoLewicki commented Aug 12, 2025

Fixes APP-2812

What changed (plus any additional context for devs)

I bumped @shopify/react-native-skia, expo and react-native-vision-camera to versions supporting 16kb, those were small version bumps so hopefully don't destroy anything.

Made patches for mmkv, quick-md5 and turbo-haptics since there are no versions supporting it yet.

Screen recordings / screenshots

Went through different app screens and did not see anything special, though I don't have extensive knowledge of the flows.
Unfortunately right now I am working on Android emulator which makes it impossible to check the flows with react-native-vision-camera and react-native-turbo-haptics.

Based on @janicduplessis comment, some skia cards:
image

What to test

There is no such warning when building app on Android:
image

and just generally that the app works well with those new versions of libraries.

Based on changed libraries:

  • Check if haptics work correctly (would be weird if they didn't since I didn't change library code at all)
  • Test if screens using camera behave correctly (vision-camera bump)
  • Check as many animations/icons as you can (rn-skia bump)

@linear
Copy link

linear bot commented Aug 12, 2025

Copy link
Contributor

@janicduplessis janicduplessis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Can you open upstream PRs so we can remove these patches later?

@WoLewicki
Copy link
Contributor Author

I already did for react-native-turbo-haptics and md5. mmkv is now on v3 but it only supports new arch so not sure if it would even be merged.

@janicduplessis
Copy link
Contributor

Ok I agree, let's leave mmkv out

@jinchung
Copy link
Member

Launch in simulator or device for 1018d1c

@jinchung
Copy link
Member

I know you mentioned for testing that the reviewer should check that the app generally works well as the rn-skia changes impact across the app, but can you add under the "What to test" the areas that should get specific attention as well (e.g, usage of camera, haptics). This section is to make QA's life easier.

And then for screen recordings - though there is nothing to really show, can you add in that section at least written acknowledgement that you confirmed on device and went through a few screens to confirm animations across the app still look the same, etc.

@WoLewicki
Copy link
Contributor Author

Sorry for the lack of information @jinchung. I updated the PR description. It might be a case that I missed something due to my lack of knowledge of how the things should look like.

@WoLewicki
Copy link
Contributor Author

I went through release notes in those libraries and haven't found anything looking bad, but you never know ofc.

@janicduplessis
Copy link
Contributor

For vision camera you can check the QR code scanner and skia these cards are basically all skia and the most likely to break

image

@WoLewicki
Copy link
Contributor Author

Ok I checked those, camera launches and cards look the same 🎉

@jinchung jinchung merged commit 9ea529d into develop Aug 13, 2025
8 checks passed
@jinchung jinchung deleted the @wolewicki/android-16kb branch August 13, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants