fix: make project android 16kb compatible#6804
Conversation
janicduplessis
left a comment
There was a problem hiding this comment.
Looks good!
Can you open upstream PRs so we can remove these patches later?
|
I already did for |
|
Ok I agree, let's leave mmkv out |
|
I know you mentioned for testing that the reviewer should check that the app generally works well as the rn-skia changes impact across the app, but can you add under the "What to test" the areas that should get specific attention as well (e.g, usage of camera, haptics). This section is to make QA's life easier. And then for screen recordings - though there is nothing to really show, can you add in that section at least written acknowledgement that you confirmed on device and went through a few screens to confirm animations across the app still look the same, etc. |
|
Sorry for the lack of information @jinchung. I updated the PR description. It might be a case that I missed something due to my lack of knowledge of how the things should look like. |
|
I went through release notes in those libraries and haven't found anything looking bad, but you never know ofc. |
|
Ok I checked those, camera launches and cards look the same 🎉 |

Fixes APP-2812
What changed (plus any additional context for devs)
I bumped
@shopify/react-native-skia,expoandreact-native-vision-camerato versions supporting 16kb, those were small version bumps so hopefully don't destroy anything.Made patches for
mmkv,quick-md5andturbo-hapticssince there are no versions supporting it yet.Screen recordings / screenshots
Went through different app screens and did not see anything special, though I don't have extensive knowledge of the flows.
Unfortunately right now I am working on Android emulator which makes it impossible to check the flows with
react-native-vision-cameraandreact-native-turbo-haptics.Based on @janicduplessis comment, some skia cards:

What to test
There is no such warning when building app on Android:

and just generally that the app works well with those new versions of libraries.
Based on changed libraries:
vision-camerabump)rn-skiabump)