Pass any AX response to the callback along with the SReg response#5
Open
tomhughes wants to merge 5 commits intorails:masterfrom
Open
Pass any AX response to the callback along with the SReg response#5tomhughes wants to merge 5 commits intorails:masterfrom
tomhughes wants to merge 5 commits intorails:masterfrom
Conversation
|
+1 for this change - I was just about to fork and make the same change myself, but I noticed in the list of forks that there are quite a few people who have done the same thing or something very similar to achieve the same effect. |
|
I've applied this patch in the new official fork. Thanks for the patch! |
…rameter 'ax' of the block
Clarifying the AX data section of the readme.
…delines and versioning.
grosser
referenced
this pull request
in grosser/open_id_authentication
Sep 17, 2013
The controller actions have been placed into a ControllerMethods module and there is now a proper Railtie for Rails 3.X applications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although authenticate_with_open_id allows both SReg and AX attributes to be requested (via the :optional and :required options) only the SReg results are passed to the callback. This commit makes it pass the AX results as well.