feat: Add support for URL query search #1283
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the courses page has support for adding tags and a few other URL params, but is missing any search param.
I think that can be useful for sharing and link purposes: e.g. https://www.mooc.fi/en/courses/?status=Active&search=cybersecurity
y
This PR adds support for that!
Unfortunately I got many issues when setting up the environment, and the pre-commit hook kept failing, even if
npm run prettierworked correctly (after I deletedbackend/.prettierrc.jsas that was incorrectly set to../.prettierrc).So, for all such reasons, I wasn't able to properly test this, so I'd need some help, either with someone else testing this or helping me set this up correctly.
Great work with all the MOOC initiative, that's an amazing opportunity! 😃