-
-
Notifications
You must be signed in to change notification settings - Fork 1
chore(ci): Publish container images via CI/CD #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
e26e5a7 to
e2e6c8b
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
e2e6c8b to
161c52c
Compare
b3f2583 to
900db84
Compare
1f2268c to
ee61e96
Compare
84c4c0e to
f85708b
Compare
24800bc to
fc91cc3
Compare
bf5092c to
f588182
Compare
cd1095b to
cdbb90a
Compare
cdbb90a to
612d76d
Compare
|
Hi @hairmare |
2e07692 to
7f05f5a
Compare
7f05f5a to
6f513b8
Compare
92c5a15 to
2961f15
Compare
|
@AareFabrik the docker docs currently mention 1. April as the target date for these rate limits:
I don't think we need to panic considering our current usage pattern, but merging this would certainly be a step towards having some more security. |
| dockerfile: './next/Dockerfile.prod' | ||
| push-default-branch: true | ||
| build-args: | | ||
| IMAGES_HOSTNAME=data.rabe.ch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (non-blocking): this value might need updating to whatever is currently on prod, it's current value seems to be in the .env file
2961f15 to
a16c9f7
Compare
a16c9f7 to
749f3b3
Compare
2080727 to
2b3d4b3
Compare
2b3d4b3 to
5037838
Compare
5037838 to
0bf0ed7
Compare
* Publish container images to ghcr.io
0bf0ed7 to
b3309ec
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Publish container images to ghcr.io based on rabe actions.
After merge this will:
ghcr.io/radiorabe/website-stack/next:latestghcr.io/radiorabe/website-stack/next:<tag>latestimage and upload the results to the GitHub security tabThis reflects our container image build best-practices. In this type of image build, we recommend using a pull-request based approach with conventional commits and semantic-release to ensure that every change is automatically tagged and released, I'll followup on this in #13.