Fix for items not being retired in non-incremental feeds #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WP_Query was used to query WP posts to mark them for retirement or process retirements. 'posts_per_page' was not specified so the default value was used (from Settings->Reading in WP admin), so only few first posts were retired, even though the feed might have more items removed from it.
Contributor
|
If this is no longer needed/relevant - please close this PR. |
Contributor
|
May I suggest to close this PR?! |
Contributor
|
This PR is probably stale at this point, and it's worth closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WP_Querywas used to query WP posts to mark them for retirement or process retirements.'posts_per_page'query parameter was not specified so the default value was used (from Settings->Reading in WP admin), so only few first posts were retired, even though the feed might have more items removed from it.I have only used the plugin with non-incremental feeds for now so can't comment on the behavior in different type of feeds. It's possible that there are more occurrences of
WP_Querybeing used in similar fashion - these are not fixed.