Fix crash on feeds containing posts with inline images (e.g. data uri's) #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I wonder if there is a way (instead of having such feed crash), to make such posts not be pulled (since they fill the database with VERY large posts) |
Contributor
|
If this is no longer needed/relevant - please close this PR. |
Contributor
|
May I suggest to close this PR?! |
Contributor
|
This PR is probably stale at this point, and it's worth closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feeds like these two inline their images using Data URI's, but this causes seg faluts in apache ( and even in php cli in testing) because of the current regex created via attributeRegex.
This two liner fixes the crash while allowing feedwordpress to support these kinds of feeds.