Add complete compatibility directory for SimplePie 1.9.0 #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 14, 2026 11:52
When feedwordpress_diagnostics_output option doesn't exist in the database, get_option() returns false instead of the default array() value, causing a PHP Warning when attempting to iterate over $output in foreach(). This issue affected installations without saved diagnostic settings. The admin interface already handled this case correctly with an is_array() check (diagostics-page.php:190-193), but the diagnostic() method did not. Cast to array() ensures $output is always iterable, preventing the warning.
Fixes PHP warnings when author mapping rules don't contain enough newline characters. Uses array_pad() to ensure explode() always returns at least 3 elements, preventing undefined array key warnings for $author_name and $author_action.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a dedicated 1.9.0 directory to the SimplePie extensions, following the existing versioning pattern.
Problem:
When running on WordPress 6.9+ (SimplePie 1.9.0), FeedWordPress falls back to the minimalist default parser. This parser lacks namespace tracking, which causes custom metadata tags like $(prefix:tag) to return none.
Solution:
Tested. Successfully restores custom namespace parsing.
Fixes: #168