Restructure project into MT-safe library. Added a CMake + Docker build system.#5
Open
Kracken256 wants to merge 2 commits intoradare:masterfrom
Open
Restructure project into MT-safe library. Added a CMake + Docker build system.#5Kracken256 wants to merge 2 commits intoradare:masterfrom
Kracken256 wants to merge 2 commits intoradare:masterfrom
Conversation
Kracken256
commented
May 3, 2024
Kracken256
commented
- Pack code into cross-platform library
- Optimized-sub-optimal code
- Patched race conditions and overflow bugs
- Added inline documentation for the C API
Collaborator
|
This looks like a hige overhaul of the original code. Can you separate the changes in different commits? |
Collaborator
|
And ideally keep the same coding style |
Author
|
I can fix the coding style. But most of the files were changed/removed. Committing individual changes doesn't make much since, there's only like 2 source files and ~15 functions. The new code is ~200x faster (I enabled optimizations). |
Collaborator
|
Yeah its a little hard and probably not much useful. Fix the code style and ill merge! Thank you!! |
Author
|
Sorry, I forget about this one. I reformatted the code using Google Style VSCode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.