fix(gateway): Fix ldap binding for setups where users can't read thei… #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
Tested successfully to work with an ACL for users to read their own groups and without it (when using bind credentials). |
behrmann
reviewed
Jun 18, 2025
Contributor
|
Hello @Cornelicorn and @behrmann, thank you very much for your contribution 👍 I'll give it a look with rackslab/RFL#54 ASAP. |
Cornelicorn
force-pushed
the
fix-ldap-bind
branch
from
15bd529 to
ebe9aff
Compare
Contributor
Author
|
Squashed the typo into the first commit |
Contributor
|
I have to release a new version of RFL with rackslab/RFL#54 landed before merging this. |
Cornelicorn
force-pushed
the
fix-ldap-bind
branch
2 times, most recently
from
4128eed to
1703803
Compare
After successful user authentication, when service bind dn and password are defined in configuration, Slurm-web now retrieves user information and user groups in LDAP with these credentials by default. This solves issues where Slurm-web is unable to retrieve user groups when users do not have read permissions in groups branch of LDAP directory. When service bind dn and password are not defined in configuration, Slurm-web keeps using authenticated user permissions lookup user information and user groups. The previous behavior can be restored by setting lookup_as_user = yes under the [ldap] section in gateway configuration file. fix rackslab#587
This is required to get LDAPAuthentifier() lookup_as_user argument.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r own groups
Closes #587
Depends on rackslab/RFL#54