Add JUNK and BEXT wav format compatibility + promisified + cleaning#25
Open
topkat wants to merge 1 commit intorackfx:masterfrom
Open
Add JUNK and BEXT wav format compatibility + promisified + cleaning#25topkat wants to merge 1 commit intorackfx:masterfrom
topkat wants to merge 1 commit intorackfx:masterfrom
Conversation
* read infos whenever there is metadata between `wave_identifier` and `fmt_identifier` chunks (like this is the case with JUNK and BEXT wav files * promisify the lib so it can be used with promises, `await` and callback * clean code with transforming var to `let` and `const` * minor readability improvements
Author
|
Hi, JUNK wav file: BEXT (broadcast extension) wav file: (I have a github error because the file is 35MB so uploaded to my server) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wave_identifierandfmt_identifierchunks (like this is the case with JUNK and BEXT wav filesawaitand callbackletandconst