Fix wrong value types & added typescript decorators & some refactoring#24
Open
Vovencia wants to merge 2 commits intorackfx:masterfrom
Open
Fix wrong value types & added typescript decorators & some refactoring#24Vovencia wants to merge 2 commits intorackfx:masterfrom
Vovencia wants to merge 2 commits intorackfx:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this code has some wrongs (block 1):
And this (block 2):
there is some confusion here..
All int values should be unsigned:
readUInt32LEnotreadInt32LEint16 = 2 bytes
int32 = 4 bytes
in block 1 some types incorrent by int size
So.. to avoid confusion, i am change type names:
uint16name for 2 bytes int &uint32name for 4 bytes intIn you logic,
integer-> 2 bytes,uinteger- 4 bytesBlock description 1:
here:
['subchunk_size','integer',4],type is 2 bytes (
integer), but real size 4 bytesand here:
['byte_rate','integer',4],P.S.
Sorry for my english..