Skip to content

Conversation

@rachetm
Copy link
Owner

@rachetm rachetm commented Feb 17, 2020

No description provided.

@rachetm rachetm requested a review from aishwary08 February 17, 2020 05:34
Copy link
Collaborator

@aishwary08 aishwary08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Use destructuring and default values.
  2. Avoid using inline styles and id selector styles
  3. Best to use class styles (Its easier for external consumer to override them)
  4. Add comments in you code base
  5. Can you come-up with a centralized implementation of mSTP and mDTP? Because it looks redundant.
  6. Create separate CSS file for each component.
  7. Prefer using const over let.
  8. Take care of the code indentation
  9. Avoid margins if you can, Prefer using Padding.
  10. Remove Commented code before pushing for review. Also, its a good practice to review the code by yourself before pushing for final review. One of the way to do it is, by comparing your branch with master/dev (whichever is your main branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants