feat(messaging): v1

[f-gate]

TODO:

• include integration tests
• complete + link docs
• update pop-api
• Runtime config and review
• regenerate weights
• signed ISMP

[sc-3644]

[Copilot]

Pull Request Overview

This PR implements messaging v1 by integrating messaging logic into various pallets and updating tests, configuration, and documentation. Key changes include updated ISMP router behavior, enhancements to messaging query and callback handling, and additional integration tests and weight documentation.

Reviewed Changes

Copilot reviewed 35 out of 35 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
runtime/devnet/src/config/ismp.rs	Updated ISMP router to use a new error variant and handler.
runtime/devnet/src/config/api/mod.rs	Added messaging read queries and weights to the API config.
pop-api/integration-tests/src/messaging.rs	Modified event assertions and updated contract instantiation in tests.
pop-api/examples/messaging/lib.rs	Minor formatting update in the contract module.
pop-api/Cargo.toml	Updated feature flags with messaging support.
pallets/api/src/nonfungibles/benchmarking.rs	Adjusted imports to include new traits.
pallets/api/src/mock.rs	Updated mock runtime to integrate messaging and ISMP modules.
pallets/api/src/messaging/transports/ismp.rs	Refactored ISMP transport: added max encoded length derives and improved deposit handling.
pallets/api/src/messaging/weights.rs	Added a new weights trait implementation for messaging calls.
pallets/api/src/messaging/deposits.rs	Introduced functions to calculate protocol and message deposits.
extension/src/lib.rs	Updated Extension type to include explicit generic specification.
Cargo.toml	Adjusted workspace members and dependency configurations.

Comments suppressed due to low confidence (2)

pop-api/integration-tests/src/messaging.rs:414

• The Contract::new function contains unreachable code after returning the struct instance. Consider removing the redundant instantiation that follows the initial return.

fn new() -> Self { ... let (address, account_id) = instantiate(CONTRACT, INIT_VALUE, function_selector("new"), vec![]); Self { address, id: account_id }

pallets/api/src/messaging/transports/ismp.rs:118

• [nitpick] Consider renaming 'Handler' to a more descriptive name like 'IsmpHandler' to improve code clarity regarding its role in processing ISMP messages.

pub struct Handler<T>(PhantomData<T>);

[evilrobot-01]

Apologies for the avalanche of comments. Tests, benchmarks and runtime config not yet reviewed as a result.

Great work on the callback deposits and use of Unbalanced, very elegant solution. Commented out integration tests and benchmarks that do not compile is disappointing.

[evilrobot-01]

PR description shows integration tests as a 'completed' todo, yet they are excluded?

[evilrobot-01]

Obviously cant merge into main until this is resolved. There is no corresponding todo in the PR description.

[evilrobot-01]

Can this be removed after a rebase please?

[evilrobot-01]

How will the contract know about this? Should it be emitted as an event instead for offchain workflow rather than error? Perhaps messages should transition to errored as well as timed out?

[evilrobot-01]

Suggested change

	// Deposit that the message has been recieved before a potential callback execution.
	// Deposit that the message has been received before a potential callback execution.

[evilrobot-01]

Shared be a shared remove function to ensure that all cleanup is done consistently across the pallet, otherwise maintainers need to know to update cleanup handling in x different places.

[evilrobot-01]

Suggested change

	crate::messaging::Pallet::<T>::deposit_event(Event::<T>::IsmpTimedOut {
	Pallet::<T>::deposit_event(Event::<T>::IsmpTimedOut {

Unnecessary prefix

[evilrobot-01]

Would prefer this is only calculated at time of deposit taken, as mentioned elsewhere.