Open
Conversation
WalkthroughThe handler now always sets Edge-Cache-Tag regardless of CDN provider and adds CloudFront support by setting amzn-cache-tag with the same deduplicated cache keys. Existing Cloudflare headers (Cache-Tag, Surrogate-Key) are retained. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Client
participant Handler as CDN Caching Handler
participant Resp as HTTP Response
Client->>Handler: Incoming request
activate Handler
Handler->>Handler: Compute & deduplicate cacheKeys
note right of Handler #f2f4f8: Edge-Cache-Tag now provider-agnostic
Handler->>Resp: Set header Edge-Cache-Tag: cacheKeys
alt Cloudflare
Handler->>Resp: Set header Cache-Tag: cacheKeys
Handler->>Resp: Set header Surrogate-Key: cacheKeys
end
alt CloudFront
Handler->>Resp: Set header amzn-cache-tag: cacheKeys
end
Handler-->>Client: Response with headers
deactivate Handler
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit