core: improve named icon detection#532
Open
charlesrocket wants to merge 1 commit intoquickshell-mirror:masterfrom
Open
core: improve named icon detection#532charlesrocket wants to merge 1 commit intoquickshell-mirror:masterfrom
charlesrocket wants to merge 1 commit intoquickshell-mirror:masterfrom
Conversation
charlesrocket
force-pushed
the
icon-provider
branch
from
b1baed0 to
75cfd3c
Compare
charlesrocket
force-pushed
the
icon-provider
branch
from
75cfd3c to
5f92890
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes weak named icon detection. The provider now can look for light or dark icons depending on the system settings (KDE/GTK).
Valid paths (that were undetectable before):
Now the provider will pull the icon from
breeze-darkif dark icons are preferred.Tested on FreeBSD via
transmission-gtk/transmission-qt.