-
Notifications
You must be signed in to change notification settings - Fork 156
Fix Snap build #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Snap build #698
Conversation
|
Btw the reason for resorting to an absolute path instead of an environment variable to get the build-stage files was because neither |
|
In order to skip having to use absolute paths I just also discovered you could copy in the build-step to the stage-step (/remove the stage-step override completely): This might be a cleaner solution |
|
Build and boot are succesful. Seems to function normally. |
|
LGTM, looks like we might need to upgrade the wrapper again though to be in line with #700? |
|
Yep that sounds logical. Just tested it and it seemed to build succesfully on WSL2 Ubuntu machine. |
|
(Builds/results of previous commits were tested on a real Ubuntu PC, I just didn't feel like rebooting my computer just now :P ) |
There were some problems with the Snap build causing it to fail:
downloadJres,downloadGStreamer,createQueleaExe64), but those tasks could not be removed because thecopyToDisttask would fail since it (copyToDist) expects the Windows components to be present./build/quelea/parts/quelea/build/dist/didn't seem to exist when testing to pack the Snap withsnapcraft pack..desktop-file contained aVersion=2019entry, but when I was building Flatpaks earlier this year, I noticed there was a warning stating that theVersionentry was incorrectly used. It appears it can only be used to specify the.desktop-file specification version, not the application's version.Fixed by:
gradle-9.1.0/bincopyToDistto only unzip a Windows JRE when present./root/parts/quelea/build/dist/. I'm unsure at this time if this is the correct path when it builds on Ubuntu/Canonical/Snapcraft servers/runners, but it worked when locally executingsnapcraft packwhich I believe simulates a normal build environment because it makes a VM in which the Snap gets packed/built.Version=entry from the .desktop file.jar/directory withapp/to be more clear what is contained inside the directory.