Skip poll based on buffer fullness #441
Open
+91
−34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
During high-throughput spike periods, Que's job polling mechanism can lead to very high database load with continuous polling, even when the job buffer is already nearly full and workers are actively processing jobs.
What is possible to be happening currently:
Changes
Add optional
skip-poll-when-buffer-above-thresholdCLI parameter defaulting to 1.0.When the buffer already has at least
skip-poll-when-buffer-above-thresholdfraction of its capacity filled, the polling is skipped for that iteration.Backward-compatibility
Currently, the polling is skipped only when the buffer is completely full.
When the new
skip-poll-when-buffer-above-thresholdparameter is not provided, it defaults to 1.0 so there's no change compared to the current behaviour.