Skip to content

Comments

fix: enable jinja templater for previously ignored test fixtures#2220

Draft
benfdking wants to merge 1 commit intomainfrom
fix/enable-jinja-templater-for-test-fixtures
Draft

fix: enable jinja templater for previously ignored test fixtures#2220
benfdking wants to merge 1 commit intomainfrom
fix/enable-jinja-templater-for-test-fixtures

Conversation

@benfdking
Copy link
Collaborator

Summary

  • Update rule test fixtures that were ignored due to missing jinja templater configuration
  • For each test using jinja syntax ({{ }}, {% %}), add templater: jinja to configs
  • Enables ~80 tests across 20 fixture files that were previously skipped

Test plan

  • Run cargo test to verify all updated fixtures pass
  • Verify no regressions in existing tests

🤖 Generated with Claude Code

Update rule test fixtures that were ignored due to missing jinja
templater configuration. For each test that uses jinja syntax
({{ }}, {% %}), add `templater: jinja` to the configs section,
allowing these tests to run properly.

This enables ~80 tests across 20 fixture files that were previously
skipped with "jinja is not set" or "jinja is not supported" messages.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@benfdking benfdking marked this pull request as draft January 25, 2026 21:36
@github-actions
Copy link

Benchmark for dc97039

Click to view benchmark
Test Base PR %
DepthMap::from_parent 54.3±1.22µs 51.4±0.69µs -5.34%
fix_complex_query 12.3±0.34ms 12.3±0.24ms 0.00%
fix_superlong 160.1±5.51ms 172.6±16.02ms +7.81%
parse_complex_query 4.1±0.06µs 4.3±0.06µs +4.88%
parse_expression_recursion 7.3±0.16µs 7.2±0.07µs -1.37%
parse_simple_query 1068.4±29.18ns 1100.9±41.76ns +3.04%

@openhands-ai
Copy link

openhands-ai bot commented Jan 26, 2026

Looks like there are a few issues preventing this PR from being merged!

  • GitHub Actions are failing:
    • PR Checks

If you'd like me to help, just leave a comment, like

@OpenHands please fix the failing actions on PR #2220 at branch `fix/enable-jinja-templater-for-test-fixtures`

Feel free to include any additional details that might help me get this PR into a better state.

You can manage your notification settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant