Conversation
git commit -m Fix
Codecov Report
@@ Coverage Diff @@
## master #33 +/- ##
=========================================
Coverage ? 35.29%
=========================================
Files ? 3
Lines ? 17
Branches ? 0
=========================================
Hits ? 6
Misses ? 11
Partials ? 0
Continue to review full report at Codecov.
|
mannau
left a comment
mannau
left a comment
There was a problem hiding this comment.
Great work! I've just found some minor issues/questions.
| @@ -1,4 +1,9 @@ | |||
| #' Meanimputation | |||
| #' | |||
There was a problem hiding this comment.
A longer function description would be nice here.
| @@ -0,0 +1,17 @@ | |||
| #' Log transforms data. | |||
| #' | |||
There was a problem hiding this comment.
Again, a short description what the function is actually doing.
| @@ -1,10 +1,20 @@ | |||
| #' Windsorize | |||
| #' Windsorizes data. | |||
| #' | |||
| if(length(x)==0){ | ||
| stop("x must be of positive length") | ||
| }else if(sum(is.na(x))>0){ | ||
| stop("x must not contain any NA") |
There was a problem hiding this comment.
Does the function have to return an error if the vector contains NA's?
The specifications says it has to return an error if the vector contains ONLY NA's.
What could be the workaround?
| }else if(sum(x<=0)>0){ | ||
| stop("x must not contain non-positive values") | ||
| }else if(sum(is.na(x))>0){ | ||
| stop("x must not contain any NA") |
There was a problem hiding this comment.
Why are no NA's allowed during the log-transform?
3 participants
Pull request to add the features described in #1 #3 #5 #6.