forked from skarmakar/exception_notification
-
Notifications
You must be signed in to change notification settings - Fork 1
Rebase to latest version 4.4.0 #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vivek295
wants to merge
212
commits into
qinvent:master
Choose a base branch
from
vivek295:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Prepend Accumulated Errors Count in Email Subject
Ignore subclasses of ignored exceptions
update rubies for travis, add rails 5.1
Fix missing MissingController class (sic)
Make `ExceptionNotifier.notify_exception` to receive a block
Before, the header of the first section was prefixed by two spaces, leading to a visual disruption.
Align output of section-headers consistently
… option. Also changing dummy cache path away from rails cache path as this was causing the tests to pass in spite of this bug.
… option. Also changing dummy cache path away from rails cache path as this was causing the tests to pass in spite of this bug.
Replacing hangover reference to Rails.cache with error_grouping_cache…
This commit adds Google Chats notifier by using the incoming webhooks. Implementation is based off the mattermost implementation.
After losing 30 minutes of my life that nobody will give back to me, i suggest we change the template provided to use a working Rails 5 syntax
changed documentation to Rails 5 - before_action
…t_for_google_chat Add Google Chats notifier
create_email is only used from deprecated methods, so we want to remove it in the near future
Refactor email notifier
Rails 6.0.0.rc2 is out
Support Rails 6
Right now, RuboCop is called for every job in the CI matrix, however there should never be a different result, depending on Ruby or Rails version. So we only run RuboCop once, in a Lint stage. The `script` part was removed as the default is `bundle exec rake` which is the same as `bundle exec rake test` in the case of this gem.
Update Ruby versions on CI, add Ruby 2.6
Replace badges with SVG versions
…_6_gemfile Add Rail 6.0 to Appraisals file
…n_ci Run RuboCop only once per CI run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.