Skip to content

resumable upload default use v2#428

Merged
YangSen-qn merged 4 commits intoqiniu:masterfrom
YangSen-qn:master
Jan 21, 2026
Merged

resumable upload default use v2#428
YangSen-qn merged 4 commits intoqiniu:masterfrom
YangSen-qn:master

Conversation

@YangSen-qn
Copy link
Contributor

@YangSen-qn YangSen-qn commented Jan 21, 2026

变更背景描述

jira issue链接

主要变更点

  • fix bug
  • new feature
  • 不兼容变更

Checklist

  • 已自测
  • 已更新Readme

@gemini-code-assist
Copy link

Summary of Changes

Hello @YangSen-qn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the use of Resumable Upload API V2 by making it the default option for all relevant upload functionalities. This change simplifies the user experience by removing the need to explicitly enable V2 for resumable uploads and ensures that the system leverages the latest API version by default for improved performance or reliability.

Highlights

  • Default Resumable Upload API Version: The default setting for using Resumable Upload API V2 has been changed from false to true across various upload commands.
  • Command Line Flags Update: The --resumable-api-v2 flag in the upload, sync, and resumeUpload commands now defaults to true, and their help descriptions have been updated accordingly.
  • Internal Configuration Change: The DefaultUploadConfig function now initializes ResumableAPIV2 to true, ensuring V2 is used by default in the underlying upload operations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@qiniu-prow
Copy link

qiniu-prow bot commented Jan 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YangSen-qn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次代码变更将分片上传的默认 API 版本切换到了 v2。代码修改本身是正确的,但这一变更会影响现有测试用例的正确性,并且对于命令行用户来说是一个不兼容的变更。具体的反馈已在代码行评论中给出。

@xgopilot
Copy link

xgopilot bot commented Jan 21, 2026

Code Review Summary

The code changes are well-implemented and consistent. However, documentation and configuration templates need updates to match the new default behavior.

✅ Approved: Code quality, security, and performance
⚠️ Action Required: Update documentation files before merging

@xgopilot
Copy link

xgopilot bot commented Jan 21, 2026

Detailed Review Findings

✅ What's Good

Code Quality: All code changes are clean and consistent across the three affected commands (qupload2, sync, rput). The flag descriptions correctly document "default is true".

Security: No security concerns. Both v1 and v2 APIs use identical authentication mechanisms and data integrity validation. V2 actually includes MD5 checksums per part for improved integrity.

Performance: No concerns. The v2 API adds minimal overhead (one extra initialization call) but provides better session management and progress tracking.

⚠️ Issues to Address

The inline comments highlight inconsistencies between the code and supporting files that should be fixed before merging.

@YangSen-qn YangSen-qn merged commit e531686 into qiniu:master Jan 21, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant