Skip to content

Conversation

@jnsiemer
Copy link
Member

Description

This PR updates...

  • binomial sampling similar to uniform and discrete Gaussian sampling by introducing a BinomialSampler, which can be used to sample multiple samples more efficiently. This seems to speed up the sampling process by a factor of 2.

Testing
All tests already existed. I just updated them.

Checklist:

  • I have performed a self-review of my own code
    • The code provides good readability and maintainability s.t. it fulfills best practices like talking code, modularity, ...
      • The chosen implementation is not more complex than it has to be
    • My code should work as intended and no side effects occur (e.g. memory leaks)
    • The doc comments fit our style guide

@jnsiemer jnsiemer self-assigned this Dec 10, 2025
@jnsiemer jnsiemer added the performance⚡ This issue or PR should improve label Dec 10, 2025
@jnsiemer jnsiemer merged commit ab87fef into dev Dec 10, 2025
2 checks passed
@jnsiemer jnsiemer deleted the update_binomial_sampling branch December 10, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance⚡ This issue or PR should improve

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants