Add delay support in openqasm 2 #275
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
qasm3_ast.DelayInstructionto the list of recognized AST nodes in theQASM2module initializer, enabling parsing and handling of delay instructions.@AndreiCod | #274
delayinstructions inOPENQASM 2;, following syntax can be used -I would recommend switching to qasm3 as
delayis not supported natively in the grammar of qasm2.opaqueis not supported in theopenqasm3parser and since the AST ofpyqasmis based off of it, the parsing of theopaqueinstructions fail. Moreover,opaque delayresults in a parsing error asdelayis a reserved keyword in theopenqasm3parser.opaqueinstructions is theexternal_gateskwarg which we provide in theunrollmethod.and specify the name in the
external_gateslist. This will instruct the pyqasm unroller to skip the gate unrolling and just validate the parameters and arguments against the provided gate definition. Full example -