Skip to content

Conversation

@vinayswamik
Copy link
Collaborator

Summary of changes

Improved Circuit Drawer

  • Implement line key retrieval and final measurement handling in moment computation for QASM.
  • Enhance depth calculation for multi-qubit gates and measurements, ensuring accurate moment representation.

Closes #248

@vinayswamik vinayswamik self-assigned this Sep 15, 2025
@vinayswamik vinayswamik added the bug Something isn't working label Sep 15, 2025
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pyqasm/printer.py 96.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@TheGupta2012
Copy link
Member

Hi @vinayswamik , can we add an image comparison test similar to the ones present in the test_mpl_drawer? You'll need to add a reference of this image in the directory and then compare against the one which is drawn dynamically.

@TheGupta2012
Copy link
Member

TheGupta2012 commented Sep 16, 2025

Also a nitpick, but please use more descriptive names for PR branches as bugs is very vague

Copy link
Member

@TheGupta2012 TheGupta2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good , thanks!

@TheGupta2012 TheGupta2012 merged commit 0764248 into main Sep 18, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] pyqasm.draw() gate ordering and "moments" across registers

5 participants