Skip to content

Conversation

@Web-Dev-Codi
Copy link
Contributor

removed > , $ from console , bash and sh command. these symbols are not proper commands and do not support clickable copy paste

removed > , $ from console , bash and sh command. these symbols are not proper commands and do not support clickable copy paste
Copy link
Collaborator

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Web-Dev-Codi,

thanks for your contribution. This makes sense.

Before integrating, could you change the occurrences of console` to sh` then?

Also, you need to remove the line break at the end of the file again because there is an automatic check that wants this.

Cheers

@Web-Dev-Codi
Copy link
Contributor Author

I implemented the requested changes, but unfortunately quality checks still fail.

I appreciate you taking the time to review my pull request.

I will discover this illusive bug and implement the changes so checks pass this time around.

Best Regards,
Brian

@RealCLanger
Copy link
Collaborator

I implemented the requested changes, but unfortunately quality checks still fail.

I appreciate you taking the time to review my pull request.

I will discover this illusive bug and implement the changes so checks pass this time around.

Best Regards, Brian

Hi Brian,

if you look here, you see that in line 63 it should still be console because that's the generated part by mksync. Then the check should work.

Maybe you also want to merge your branch with master because I just added a small change e66c80d to accept line breaks at the end of README.md.

Cheers
Christoph

@Web-Dev-Codi
Copy link
Contributor Author

Updated and Thank you for your patience.

Best Regards
Brian

Copy link
Collaborator

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thanks for your contribution.

@RealCLanger RealCLanger merged commit f42ffee into pytr-org:master Jan 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants