Merged
Conversation
Contributor
💊 CI failures summary and remediationsAs of commit 3fd2e16 (more details on the Dr. CI page):
1 failure not recognized by patterns:
1 job timed out:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
NicolasHug
approved these changes
Oct 26, 2021
fmassa
approved these changes
Oct 26, 2021
Member
|
LGTM, I'd just make this a code quality tag instead of bugfix |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 26, 2021
Reviewed By: fmassa Differential Revision: D31921932 fbshipit-source-id: 154bfac4194a083d363e33f640ca30af3f63b63c
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FBsync PR #4743 broke linter. This one fixes it.