Deduplicate experiment configs by deriving from base model configs#2437
Open
yiming0416 wants to merge 1 commit intomainfrom
Open
Deduplicate experiment configs by deriving from base model configs#2437yiming0416 wants to merge 1 commit intomainfrom
yiming0416 wants to merge 1 commit intomainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
yiming0416
force-pushed
the
yiming/fix_exp_readme
branch
from
966cbd7 to
dea738b
Compare
tianyu-l
reviewed
Feb 25, 2026
Comment on lines
13
to
14
| class CompilerToolkitTrainer(Trainer): | ||
| @dataclass(kw_only=True, slots=True) | ||
| class Config(Trainer.Config): | ||
| compile: CompilerToolkitCompileConfig = field( | ||
| default_factory=CompilerToolkitCompileConfig | ||
| ) | ||
| Config = CompilerToolkitConfig |
Contributor
There was a problem hiding this comment.
Don't need this alias? Can just define CompilerToolkitTrainer.Config here (replacing CompilerToolkitConfig)
Contributor
Author
There was a problem hiding this comment.
Done. But l left CompilerToolkitCompileConfig and the newly added to_compiler_toolkit_config in the newly created configs.py
yiming0416
force-pushed
the
yiming/fix_exp_readme
branch
from
dea738b to
df05137
Compare
tianyu-l
approved these changes
Feb 25, 2026
| from . import model_registry | ||
|
|
||
|
|
||
| def compiler_toolkit_llama3_debugmodel() -> CompilerToolkitTrainer.Config: |
Contributor
There was a problem hiding this comment.
hmmm, I noticed that using strings as config names can benefit such use case more
yiming0416
force-pushed
the
yiming/fix_exp_readme
branch
from
df05137 to
85cdc2f
Compare
yiming0416
force-pushed
the
yiming/fix_exp_readme
branch
from
85cdc2f to
b2fa432
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to_compiler_toolkit_config()andto_simple_fsdp_config()converter functions that create experiment configs from base model configs, eliminating duplicated field definitionsMODEL→MODULEenv var name in READMEs