Adding gpt_oss_20b and gpt_oss_120b to config_registry.py#2432
Open
chelsea0x3b wants to merge 2 commits intopytorch:mainfrom
Open
Adding gpt_oss_20b and gpt_oss_120b to config_registry.py#2432chelsea0x3b wants to merge 2 commits intopytorch:mainfrom
chelsea0x3b wants to merge 2 commits intopytorch:mainfrom
Conversation
chelsea0x3b
requested review from
fegin,
tianyu-l,
wconstab and
wwwjn
as code owners
meta-cla
bot
added
the
CLA Signed
tianyu-l
reviewed
Feb 24, 2026
Comment on lines
85
to
88
| checkpoint=CheckpointManager.Config( | ||
| interval=10, | ||
| last_save_model_only=False, | ||
| ), |
Contributor
There was a problem hiding this comment.
The configs for checkpoint, validator, log_freq for these two production models seem toy. Could you maybe refer to DeepSeek and update them to be slightly more realistic? Thanks!
Contributor
|
please fix linting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with